Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we meddle with the locale in toLocaleString() calls? #46

Open
Boldewyn opened this issue Feb 28, 2017 · 0 comments
Open

Should we meddle with the locale in toLocaleString() calls? #46

Boldewyn opened this issue Feb 28, 2017 · 0 comments

Comments

@Boldewyn
Copy link
Contributor

Example: In src/tools/format_dates.js we call

return (date.toLocaleTimeString || date.toTimeString).call(date);

There we should perhaps add our knowledge of the requested locale from hyperform.setLanguage() calls.

date.toLocaleTimeString(get_current_language())

with get_current_language() to be written in components/localization.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant