Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepDown function not working #118

Open
thomascoppein opened this issue Sep 30, 2022 · 5 comments
Open

StepDown function not working #118

thomascoppein opened this issue Sep 30, 2022 · 5 comments

Comments

@thomascoppein
Copy link

The stepDown function on a number input is not working. The stepUp function works perfect.
The is no error or warning shown.

@Boldewyn
Copy link
Contributor

Oh. Thanks for the report! I’ll investigate.

@Boldewyn
Copy link
Contributor

It’s this line, but I need to figure out again, how exactly it supports dates, too, before I can change it:

https://github.com/hyperform/hyperform/blob/master/src/tools/get_next_valid.js#L70

@Boldewyn
Copy link
Contributor

Addendum: Apparently one should not try to use the number feature of stepDown() at the moment unless they are interested in ridiculously wrong results.

Boldewyn added a commit that referenced this issue Sep 30, 2022
Dates do not work correctly, yet.

Cf. #118
@dietervyncke
Copy link

Is there any update on this topic. Can these fixes be released?

@Boldewyn
Copy link
Contributor

Yes, thanks for bringing this to my attention again! In principle the fix is ready but I wasn’t able to test it appropriately (and generalize it as much as I wanted). The problem is, that stepUp/stepDown isn’t yet working reliably with type=date and related inputs yet, and I wanted to fix those as well with the same release. If I can’t make that working this week, I’ll do a “partial release” of the current fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants