Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirrored video results for DyNeRF dataset #61

Open
ktkt2020 opened this issue Jan 3, 2024 · 1 comment
Open

Mirrored video results for DyNeRF dataset #61

ktkt2020 opened this issue Jan 3, 2024 · 1 comment

Comments

@ktkt2020
Copy link

ktkt2020 commented Jan 3, 2024

Hi,

Thanks for your nice work!

Here is a small issue about the mirrored video results (flipped the left and right). It will appear when we rendering the DyNeRF dataset.
image

I found that the poses returned by average_poses and viewmatrix in 4DGaussians/scene/neural_3D_dataset_NDC.py were left-handed.
Should we change these to right-handed instead?
i.e.,

    # 4. Compute the x axis
    x = normalize(np.cross(y_, z))  # (3)

    # 5. Compute the y axis (as z and x are normalized, y is already of norm 1)
    y = np.cross(z, x)  # (3)

and

    m[:3] = np.stack([vec0, vec1, vec2, pos], 1)
@guanjunwu
Copy link
Collaborator

Thank you for your suggestion!
Rendering validation video will not affect experiment results in my paper and only for visualization. And I'll fix it in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants