Allow disabling hb_id

[slashmo]

When using Distributed Tracing with a metadata provider, Hummingbird logs get span and trace ID metadata values automatically. This makes the hb_id metadata value a bit superfluous and it adds unnecessary bloat to the log statements. Therefore, it would be great if one could disable it.

[adam-fowler]

hb_id allows you to associate a trace entry with entries in your log.

[slashmo]

hb_id allows you to associate a trace entry with entries in your log.

Isn't that what the metadata provider provided trace/span IDs already do?

[thoven87]

hb_id allows you to associate a trace entry with entries in your log.

is hb_id used internally to attach span_id/trace_id to the logger? I just started playing with Hummingbird along with swift-otel. I noticed each log has span_id, trace_id and hb_id, since swift-otel does support log export with OTEL yet; I will try running Grafana agent to see if I can correlate logs with traces.

[slashmo]

span_id and trace_id are attached via the logging metadata handler from swift-otel. hb_id is not related to that. Log correlation works well with various observability tools.

[thoven87]

span_id and trace_id are attached via the logging metadata handler from swift-otel. hb_id is not related to that. Log correlation works well with various observability tools.

I think I understand what hb_id is now. Please correct me if I am wrong @adam-fowler hb_id can be interpreted as request_id (an idempotency key) which can used to identify retries, it can be used to guaranteed at least once delivery e.t.c. Moreover, hb_id can be injected into any subsequent calls to other services to follow a request journey across external services as well.

[adam-fowler]

Sorry took so long to reply.

hb_id is used to identify log entries that belong to a single request regardless of whether you are using Tracing or not. If the logger is passed down to services the request uses then those services log entries will include it as well.

If you really want to remove the hb_id metadata from your log entries you could write a middleware that removes it from the logger.

Originally I wanted to use metadata providers in Hummingbird but I haven't found a method where I can use them without trampling over metadata from other system eg swift-otel

@slashmo Out of interest when are the trace-id and span-id set?