-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing interface when you attach a file to a post #6933
Comments
The audio, image, and video file types have been added for mobile. |
Ah! Ok, now I understand my 'mistake'. If I want to insert another kind of file (e.g. a pdf file) I need to click the "image button" (which is also confusing !) in the menu bar. |
I agree it's confusing. Many of our users are certainly confused by it. Also to click the 'upload' button for files, but instead to block the dropdown menu for images, audio etc feels a bit duplicative. |
@spoorun I agree. |
We are aware of this problem and are actively looking for a good fix for this! Thank you for your suggestions :) |
Perhaps we could implement following as a workaround. We replace the "Split Button" (Left side general Upload, Right Side More) with one button which always shows the dropdown menu.
|
@luke- What I would do (not sure, first idea reviewing the code): Add
Rewrite humhub/protected/humhub/modules/file/widgets/FileHandlerButtonDropdown.php Lines 62 to 82 in 72b0bb8
It means we must remove humhub/protected/humhub/modules/content/widgets/views/wallCreateContentFormFooter.php Lines 58 to 65 in 72b0bb8
Do you think we should do this? |
@marc-farre Thank you for your research here. Here are a few thoughts without having looked at the code in detail.
|
@luke- Yes, that's a good solution, I think. So if you agree, when I have time (as it's for
In all modules, the humhub/protected/humhub/modules/content/widgets/views/wallCreateContentFormFooter.php Line 66 in 72b0bb8
If not, the default handler list will be used. It seems to concern the Messenger and cFile modules. I'll also update them. 2 button types:
|
@marc-farre Sounds good to me! Let me know if I can support you! |
When you want to attach a file to a post you get this menu
This is confusing because in practice you can attach many other kinds of file (pdf for example) and as long as you dont try you dont know you can.
Not a major issue, but it could be improved.
The text was updated successfully, but these errors were encountered: