Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating manual-install.zip #644

Open
rmccue opened this issue Jul 18, 2023 · 4 comments
Open

Deprecating manual-install.zip #644

rmccue opened this issue Jul 18, 2023 · 4 comments

Comments

@rmccue
Copy link
Member

rmccue commented Jul 18, 2023

We get a lot of issues around the use of manual-install.zip with various small bugs, breakages in the build system, and confusion around it. This isn't something that we use at HM, and it shows - this is why our support policy states that we use what we ship, as if this was broken for us, it'd be fixed in a matter of hours.

Right now, it's a poor experience for anyone trying to install the plugin, and isn't meeting our standards. As a result, we're going to remove this, and require the use of Composer.

If anyone in the community would like to pick up maintaining this, you're welcome to start a third-party repo that handles builds :) (Here's the old workflow for your reference.)

@wwwXpert
Copy link

That's unfortunate. I've been using this for a few years without issue. Most of the issues aren't due to the plug-in itself but to a combination of things, e.g. PHP function version deprecation, AWS permissions / settings, file system permission, configs, conflicts, etc...

@hj-collab
Copy link

I'm also disappointed with the decision as I never had any issues on dozens of sites using this plugin. But I can understand your decision. I'll see if I can fork and maintain it.

@rmccue
Copy link
Member Author

rmccue commented Jul 22, 2023

Appreciate the feedback here.

We'll aim not to intentionally break compatibility with anyone who wants to manually install the plugin and the SDK, and we won't require installation via Composer at the project (WordPress-wide) level. If you're not using Composer for everything else, installation into your plugins directory should be as simple as:

git clone https://github.com/humanmade/S3-Uploads.git s3-uploads
cd s3-uploads
composer install

(And requireing the autoload file.)

But we'll no longer provide a prebuilt zip with this bundled, and you'll be using it this way at your own (and higher) risk. :)

@kresnasatya
Copy link

I test in my local environment, I also get the issue cannot install s3-uploads plugin provided by Humanmade with WP CLI.

image

I'm using WordPress version 6.3 with PHP 8.2 (Laragon).

After do some tweaks by fork this repository, now I can install s3-uploads plugin with WP CLI. Here are some tweaks I do.

  1. Update version phpunit/phpunit to version ^9.0.
  2. Remove pcov/clobber because the coverage test has been include with phpunit/phpunit.
  3. Update GitHub workflow by update PHP version to 8.2 and update ramsey/composer-install to version 2.

Here's my fork repository: https://github.com/kresnasatya/S3-Uploads/tree/update-dev-deps

Here's my command to install updated s3-uploads plugin with WP CLI.

wp plugin install https://github.com/kresnasatya/S3-Uploads/releases/latest/download/s3-uploads.zip --force
wp plugin activate s3-uploads
wp s3-uploads verify

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants