Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalStreamWrapper->getLocalPath() giving false negative on windows machines #600

Open
rasmuswinter opened this issue Aug 23, 2022 · 0 comments
Open

LocalStreamWrapper->getLocalPath() giving false negative on windows machines #600

rasmuswinter opened this issue Aug 23, 2022 · 0 comments

Comments

@rasmuswinter
Copy link

rasmuswinter commented Aug 23, 2022 •
edited

getLocalPath uses forward slashes to construct the local file path for a file, then does a substring check against the real upload directory. On Windows, this directory contains backslashes, so the check fails and the function returns an empty string

Fixed in PR #636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rasmuswinter