Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce reliance on theme stylesheet #25

Open
abuyoyo opened this issue Mar 4, 2020 · 0 comments
Open

Reduce reliance on theme stylesheet #25

abuyoyo opened this issue Mar 4, 2020 · 0 comments

Comments

@abuyoyo
Copy link

abuyoyo commented Mar 4, 2020

This is related to #24 but perhaps much easier to implement.
It only requires css rules applied to the Restplain-specific elements.
Specifically, reduce all reliance on theme's body styling.

Attached screenshot of Restplain page on site with following style:

body{
  background-color: black;
  color: white;
  direction: rtl;
}

restplain
Not a :happy-face:

IMHO Restplain page should use user_locale() and not site_locale() but either way, current page is not i12n-ized or l10n-ized. So it should set direction: ltr explicitly. As well as specifically style all 3 main colums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant