Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing implementation of doc embeddings during inference #338

Open
valedica opened this issue Mar 11, 2022 · 0 comments · May be fixed by #339
Open

Missing implementation of doc embeddings during inference #338

valedica opened this issue Mar 11, 2022 · 0 comments · May be fixed by #339

Comments

@valedica
Copy link

Document embeddings are not calculated during inference in neuralcoref.pyx, but they are left at zeros.

doc_embedding = numpy.zeros(SIZE_EMBEDDING, dtype='float32') # self.embeds.get_average_embedding(doc.c, 0, doc.length + 1, self.hashes.puncts)

This causes a mismatch between inference and training input features (doc embeddings during training are correctly calculated in document.py). Is it a bug or is it intentional? There is a call to a method get_average_embedding as a comment but it does not exist.

@valedica valedica changed the title Missing implementation of doc embedding during inference Missing implementation of doc embeddings during inference Mar 11, 2022
@valedica valedica linked a pull request Mar 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant