Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #101

Open
lolmaus opened this issue Sep 7, 2017 · 3 comments
Open

Remove dead code #101

lolmaus opened this issue Sep 7, 2017 · 3 comments

Comments

@lolmaus
Copy link

lolmaus commented Sep 7, 2017

Hi!

I've discovered addon/components/slide-toggle which hasn't been updated since 2015, isn't documented and is like non-functional.

Until Ember CLI supports tree shaking, this dead code increases app's distro size.

Please remove it. You can keep it in a branch.

@lolmaus
Copy link
Author

lolmaus commented Sep 7, 2017

There's probably more dead code like that.

@eriktrom
Copy link
Member

eriktrom commented Sep 8, 2017

and is like non-functional.
There's probably more dead code like that.

LOL - nicely put - yes, i was just in this lib for a couple hours digging out issue w/ pr 102 - saw some dead soldiers - we should probably use something like broccoli-concat-analyser then go from there.

Open to PR for low hanging fruit, like slide-toggle

@eriktrom
Copy link
Member

eriktrom commented Sep 8, 2017

(also i didn't write this lib and dont actually use it in prod, so would be better if someone who does removed the code - i'm not sure what is and is not used without going file by file, fyi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants