Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: add canonical documentation which can be reused by all implementations #74

Open
boronine opened this issue May 1, 2020 · 3 comments

Comments

@boronine
Copy link
Member

boronine commented May 1, 2020

Suggested by @mity here: hsluv/hsluv-c#6 (comment)

@mity
Copy link
Member

mity commented May 2, 2020

This should imho be covered by such documentation:

  • All input parameters, their meaning and expected ranges.
  • All return values, their meaning and expected ranges.
  • A note HPLuv color space covers only a subset of all possible RGB triplets.
  • (For RgbToHpluv) How to correctly detect the input RGB falls outside the HPLuv space. (Have all the three return values to be checked or is e.g. just checking the saturation falls in 0...100 good enough?)
  • (For RgbToHpluv) For any RGB input outside the HPLuv color space, how to get "the closest" valid HPLuv color, in some reasonable sense. (Does e.g. clamping one or more values as returned by the function RgbToHsluv into the valid HPLuv colorspace work?)

@boronine
Copy link
Member Author

Just wanted to thank @mity for writing this up and leave my approval. I encourage anyone to take a stab at this. If left open, I might do it myself when I get some free time this year.

@boronine
Copy link
Member Author

HPLuv clamping issue encountered here: #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants