-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media keys not working #61
Comments
Try dumping hid descriptors first, I'm guessing this is appearing as something else other than keyboard... I don't have anything to test on while trying to provide support for this... I could try making a blind attempt at fixing it but that's not easy without testing. |
I have the same issue with my Logitech G815 - the volume control doesn't work tthrough the deskhop. |
I hope this will help:
|
Does it help? Can I do anything else to help to debug the issue? |
I have the same problem with a Keychron K3 Pro:
I would also like to help to debug this. Is there anything we could do? |
You have: Usage Page (Consumer), ; Consumer (0Ch) and I don't have anything similar to test with / develop on. Supporting a heterogeneous device ecosystem with every keyboard having a wildly different set of keys and implementations is quite tricky. I have a few ideas how to potentially address this, but they are either shitty, complicated or both :) Any good suggestion and some domain knowledge on how to provide better support for these additional keys is more than welcome! |
I'm not a developer nor do I have insight into HID. I naïvely came up with the thought that those keys in question are detected by Linux (Debian) without the need for any configuration. Could there be learned something from that how to handle the kind of hid used here? A side question: does anybody know of a keyboard offering keys for mute on/off, volume up/down, play/pause that works with deskhop (and Linux)? Update: Added this as a request for a list of hardware/configurations that are known to work or not work or partly work. |
Just to add another keyboard as well, this is a Glorious GMMK Pro with Via firmware:
The Glorious creates a lot of devices:
Device 10 has the media keys:
|
It's very hard for me to debug remotely, but I've decided to open PP donation fund to purchase 1-2 keyboards/mice with those fancy buttons and rotary knobs, NKRO etc. That would enable me to at least try getting this to work for more people and improve the overall user experience... |
Cool, I just transferred some funds. Hopefully it will help to fix this issue :). Thanks for all the effort so far, it seems to develop in a mature product. |
Thank you, you really overdid it. If anyone has any cheap keyboards with knobs/media buttons to recommend, that would be great. |
Well, a nice approach could be to start with QMK capable keyboards, but they're not exactly cheap. Perhaps a Keychron, like this one: If you want to buy a Keychron to use for the really long run I can recommend the Q-series (like the Q2). They're much more expensive, but the base is made out of metal and they're made to last a lifetime. Another option could be to buy a logitech with media keys, but I don't have such a keyboard myself so it would be hard for me to recommend one. |
I have a keyboard I like and use, so really don't need anything expensive/fancy. Just something that will replicate the not working things so I can try to fix it and improve overall user experience by having the buttons work (worst case some configuration/mapping is needed). Also, rewriting the hid parser in a bit more universal way is something I need to do and that should take care of things like NKRO support. From that point on, most keyboards and mice should work sufficiently well. Then further improve mac/win workarounds and basic usability should be there. Some things are also ugly and dumb, those need a rework so I can not be ashamed of them anymore, but as long as it kinda works... :) |
Anyone up for some testing? I have partial support for media keys (no custom array ones yet, mostly generic variable ones should work). |
I'll give it a try, thanks! |
Wow awesome! Just tried it with my keychron (with QMK) and it works great! I do have another bug though; in QMK I have programmed that the fn-key+ESC shuts down the computer (well, the dialog pops up), that key combination does not work unfortunately. |
That might be the system control section, also doable. I finally got my keychron with those knobs and media keys, so now I somewhat understand how they work :) |
@hrvach would you mind sharing the code in a branch or something? It doesn't work for me, but I would like to take a look what's different on my Logitech. Thanks for considering! |
@jalmeroth I'll publish it soon after cleaning it up, can you please do usbhid-dump -e all and press a couple of media keys for me? Usage Page (Consumer), ; Consumer (0Ch) |
Yes, this looks like the right descriptor. Here is the usbhid-dump output #47 (comment) I try to keep all relevant infos in this issue. |
@jalmeroth any difference with deskhop-media-keys-2.zip ? |
@hrvach standard keys are working but media keys are not send. Is report mode enabled? Do you might wanna create a debug build so we can see what's happening on the deskhop side in the console? |
@jalmeroth consumer control is likely not sent in boot mode with that particular model ... :-| should start working once I get nkro support done. |
Just checked using 0.52 with a Cherry STRAIT 3.0 BLACK. It seems that all keys are working now. The keys I found formerly not working were:
Thanks for the great work! As far as I'm concerned this can be closed. |
cc: @chri2 apologies to bug you, I'd appreciate some help with testing does this still upcoming release still work for your use case? |
I'm using a Cherry Strait 3.0 keyboard. It seems that the media keys for
<play/pause>
,<volume down>
,<mute>
,<volume up>
are represented by there own input device.dmesg when connecting:
When trying
evtest
I get a selection of three devices for the keyboard:The normal keyboard on
event11
is what works using deskhop. Events for media keys can be found onevent12
:These are not relayed when the keyboard is connected through deskhop.
I didn't find out what the third
event13
device is used for - maybe it's just there even though no keys are connected.The text was updated successfully, but these errors were encountered: