Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggplot2::movies now is its own CRAN pkg: need update in streamgraph vignette #20

Open
data-steve opened this issue Apr 8, 2016 · 1 comment

Comments

@data-steve
Copy link

Really enjoy your work. Playing with your vignette last night and found a dependency change

This is from Data Expectations section of vignette; needs a sligth update in sourcing movie data from ggplot2:

ggplot2::movies %>%      # change this line
  select(year, Action, Animation, Comedy, Drama, Documentary, Romance, Short) %>%
  tidyr::gather(genre, value, -year) %>%
  group_by(year, genre) %>%
  tally(wt=value) %>%
  ungroup %>%
  streamgraph("genre", "n", "year") %>%
  sg_axis_x(20) %>%
  sg_fill_brewer("PuOr") %>%
  sg_legend(show=TRUE, label="Genres: ")

it now should be

install.packages("ggplot2movies")

ggplot2movies::movies %>%      
  select(year, Action, Animation, Comedy, Drama, Documentary, Romance, Short) %>%
  tidyr::gather(genre, value, -year) %>%
  group_by(year, genre) %>%
  tally(wt=value) %>%
  ungroup %>%
  streamgraph("genre", "n", "year") %>%
  sg_axis_x(20) %>%
  sg_fill_brewer("PuOr") %>%
  sg_legend(show=TRUE, label="Genres: ")
@hrbrmstr
Copy link
Owner

hrbrmstr commented Apr 8, 2016

thx. i had changed it in the README.md but didn't dig into the vignette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants