Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyglotInspector can't inspect hidden elements of large Arrays #143

Open
janehmueller opened this issue May 10, 2021 · 5 comments
Open
Assignees

Comments

@janehmueller
Copy link
Contributor

Large arrays are shortened in the Inpsector so that the head and tail are displayed and the middle part of the array is hidden by an ellipsis. When clicking on that ellipsis, one can enter and index to inspect. This works with the base Inspector, but with the PolyglotInspector, the element is not found.

image
image

@fniephaus
Copy link
Member

Thanks! I've asked @LinqLover to take a look at this.

@LinqLover
Copy link
Collaborator

I just proposed a fix for Squeak Trunk, could you please confirm that it resolves the issue for you? :-)

[squeak-dev] Changeset: fix-generic-inspectOne-with-truncation.cs

The changeset will make its way into the Trunk as soon as someone approves and merges it ...

@fniephaus
Copy link
Member

Excellent, thanks @LinqLover! With the changeset, the polyglot inspector seems to work fine. Great!

@LinqLover
Copy link
Collaborator

Great! Please feel free to merge the changeset into the Trunk if it looks good to you. :-)

@fniephaus
Copy link
Member

Let me leave this to @marceltaeumel. He might be the better reviewer as he's familiar with the code already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants