Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Squeak 5.3] Installation asks for author initials #383

Open
LinqLover opened this issue Sep 11, 2022 · 4 comments
Open

[Squeak 5.3] Installation asks for author initials #383

LinqLover opened this issue Sep 11, 2022 · 4 comments

Comments

@LinqLover
Copy link
Contributor

While installing Squot in a fresh Squeak 5.3 image, I hit an unexpected "enter author initials" question:

image

In other scenarios, this might break CIs. Why can't we use -override extension methods here?

@j4yk
Copy link
Collaborator

j4yk commented Sep 11, 2022

Because I did not want to override the existing methods and functionality if it is already present.

Now that Squeak 6.0 is here I could reconsider.

@LinqLover
Copy link
Contributor Author

LinqLover commented Sep 13, 2022

But now you could put the extension methods into the right compatibility package, couldn't you? Wouldn't this allow for clearer tracking of the origin of these overrides? Same for 21e8664#diff-e8aa5f417f3a14ad795b10c7c80746624d2c2a785cd04e3f5d5feab8b698cfe.

@j4yk
Copy link
Collaborator

j4yk commented Sep 14, 2022

Since this is in FileSystem-Git, not in Squot, I would have to create compatibility packages there in the first place. But wait, maybe the SquotCompatibility-SqueakCommon package is actually mislabelled now, since I certainly did not rely on Pharo methods in the "new" code (as compared to the "old" code in FileSystem-Git and FileSystem)!

@j4yk
Copy link
Collaborator

j4yk commented Sep 14, 2022

Indeed, only FileSystem-Git code uses things from SquotCompatibility-SqueakCommon. With the old name Pharo-Compatbility it did not matter which code used it. :-) So I could rename that package.

But for the stub methods for read-only objects I would anyway need another compat package because the methods are available in Squeak 6.0, and the SquotCompatibility-Squeak50 has indeed methods used by Squot, not by FileSystem-Git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants