Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ICAddressBook to really use ICContacts #411

Open
laugengebaeck opened this issue Jun 17, 2021 · 0 comments
Open

Change ICAddressBook to really use ICContacts #411

laugengebaeck opened this issue Jun 17, 2021 · 0 comments
Labels
good first issue Good possibility to get an overview of the system. Great point to start for the new team! refactor

Comments

@laugengebaeck
Copy link
Contributor

laugengebaeck commented Jun 17, 2021

This will probably be an issue for the next SWT group.

In #396 we added the ICContact class abstracting contacts, but in fact only used it to generate strings to be added to the address book. When we added a sorting functionality in #403, it became apparent that this is not a good idea, as sorting code tends to get really ugly. Nevertheless, we didn't change it since this would have necessitated a big UI change in the ICAddressBookDialog (for details see the linked pull request).

Now, the ICAddressBook should be changed so that it really uses ICContacts. For this, also changes to the sorting code and the UI of the ICAddressBookDialog will be necessary, since the currently used PluggableTreeSpec only supports displaying strings directly.

@laugengebaeck laugengebaeck added refactor good first issue Good possibility to get an overview of the system. Great point to start for the new team! labels Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good possibility to get an overview of the system. Great point to start for the new team! refactor
Projects
None yet
Development

No branches or pull requests

1 participant