Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests related to ICEndpointCommandTest #360

Open
JuliaJoch opened this issue Jul 31, 2020 · 1 comment
Open

Refactor tests related to ICEndpointCommandTest #360

JuliaJoch opened this issue Jul 31, 2020 · 1 comment
Labels

Comments

@JuliaJoch
Copy link
Contributor

The tests of ICEndpointCommandTest and several other older Test Classes have so many test smells that we are overwhelmed by all the changes that would be necessary in order to make this readable.

For example there is code duplication for setting up the email objects that will be tested which could be refactored into the setup method.
Also there are tests with a lot of assertions in one method.

@shm0sby shm0sby changed the title refactor tests Refactor tests related to ICEndpointCommandTest Jul 31, 2020
@MrHenrik
Copy link
Contributor

In addition the tearDown in ICEndpointCommandTest does not delete the folders which it builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants