Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename unsqueakish parameter names #217

Open
Paulpanther opened this issue Jun 10, 2019 · 1 comment
Open

Rename unsqueakish parameter names #217

Paulpanther opened this issue Jun 10, 2019 · 1 comment
Labels
discussion Needs to be discussed with the team refactor

Comments

@Paulpanther
Copy link
Contributor

Some parameter names, like in for: username using: password should be renamed. There should be an a before the parameter name and it should declare its type and not its interpretation. But since both parameters are String we cannot have aString and aString. What is the correct/squeakish way?

@Paulpanther Paulpanther added discussion Needs to be discussed with the team refactor labels Jun 10, 2019
@timgarrels
Copy link
Contributor

imho for: aUsernameString using: aPasswordString if the datatype of the parameter is not obvious. In this case I'd suggest aUsername, aPassword.
But parameters like data are used in our codebase as well. Those could be instances of ICEndpoint, Dictionary, Collection or whatever.
In those cases the datatype should be explicitly named

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Needs to be discussed with the team refactor
Projects
None yet
Development

No branches or pull requests

3 participants