Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow showing bech32 keys for imported wallet #277

Open
staktrace opened this issue Jan 11, 2022 · 1 comment · May be fixed by #279
Open

Allow showing bech32 keys for imported wallet #277

staktrace opened this issue Jan 11, 2022 · 1 comment · May be fixed by #279

Comments

@staktrace
Copy link

I'd like to be able to do something like wagyu bitcoin import-hd -m "..." -d "m/84'/0'/0'/0/0" -f bech32 such that it prints out the address in bech32 format instead of P2PKH. Currently there doesn't appear to be any way to do this without code modification.

I'm happy to write a PR for this, but is this something you'd be interested in?
@staktrace
Copy link
Author

After poking around the code some more the structure of the CLI seems quite confusing. For example it's possible to run a command like wagyu bitcoin -f bech32 import-hd "cloud soup script pool hammer cage embrace permit remember uncover weather end" because the bitcoin command takes a -f argument even though the import-hd subcommand does nothing with it.

Also the wording for -f in wagyu bitcoin import -h is confusing, it says "Imports a wallet with a specified format" but the format has nothing to do with the import; it's all about how the address is outputted.

staktrace added a commit to staktrace/wagyu that referenced this issue Jan 25, 2022
@staktrace
Allow outputting different formats for bitcoin import-hd command
04deb5a 
This allows doing things like `bitcoin import-hd -m <...> -f bech32`
which then prints the address in bech32 format; previously this
was not possible.

Fixes howardwu#277.
@staktrace staktrace linked a pull request Jan 25, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow outputting different formats for bitcoin import-hd command staktrace/wagyu
1 participant
@staktrace