Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of @typescript-eslint packages? #1841

Open
JeppeHS opened this issue Apr 20, 2021 · 1 comment
Open

Version of @typescript-eslint packages? #1841

JeppeHS opened this issue Apr 20, 2021 · 1 comment

Comments

@JeppeHS
Copy link

JeppeHS commented Apr 20, 2021

We use the packages '@typescript-eslint/eslint-plugin' and '@typescript-eslint/parser' with ESLint.
We have tried to keep our versions of these and ESLint in sync with HoundCI, but recently we started getting:

image

So we tried upgrading the versions of '@typescript-eslint/eslint-plugin' and '@typescript-eslint/parser' to the latest.
But now we just get 'Smells good..' regardless of what ESLint errors there might be in the code.

Screenshot 2021-04-20 at 12 59 54
image

Our package.json:

...
"@typescript-eslint/eslint-plugin": "^4.22.0",
"@typescript-eslint/parser": "^4.22.0",
...
"eslint": "^7.7.0",
"eslint-config-prettier": "^8.2.0",
"eslint-plugin-import": "^2.22.1",
"eslint-plugin-prettier": "^3.4.0",
"eslint-plugin-react": "^7.23.2",
"eslint-plugin-react-hooks": "^4.2.0",
...

Our .hound.yml:

...
eslint:
  enabled: true
  config_file: .eslintrc
  version: 7.7.0

Our .eslintrc:

{
  "parser": "@typescript-eslint/parser",
  "extends": [
    "eslint:recommended",
    "prettier",
    "plugin:@typescript-eslint/recommended",
    "plugin:react/recommended",
    "plugin:import/errors",
    "plugin:import/warnings"
  ],
  "plugins": ["react", "react-hooks", "prettier", "@typescript-eslint"],
...

Could you advise us how to proceed or provide the versions of '@typescript-eslint/eslint-plugin' and '@typescript-eslint/parser' at your backend?

As a side-note we have an ongoing problem with optional changing which results in a parsing error.
image
But I see others have pointed that out as well.

@yidingww
Copy link

yidingww commented Aug 10, 2021

I am having the same issue with eslint 7.7.0, @typescript-eslint/eslint-plugin 4.29.0, @typescript-eslint/parser 4.29.0

On my local, eslint CLI works perfectly.
But on my PR, hound never report any violations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants