Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate postmark webhooks by IP #7

Open
James4645 opened this issue Sep 29, 2022 · 2 comments · May be fixed by #31
Open

Authenticate postmark webhooks by IP #7

James4645 opened this issue Sep 29, 2022 · 2 comments · May be fixed by #31

Comments

@James4645
Copy link

Is your feature request related to a problem? Please describe.
For the Postmark provider it (annoyingly) authenticates the webhook using one of my app's users via HTTP basic auth. It's kinda silly to have to setup a special user in my app just to authenticate the webhooks. Then I would want to add logic to my login page's controller to exclude the possibility of logging in as that user on the main website for if those credentials where somehow leaked.

Describe the solution you'd like
In my opinion it makes much more sense to authenticate the webhook by IP address instead of the current method. And maybe add a config value to add additional IP's such as localhost or other special purpose IP's for testing.

Describe alternatives you've considered
I have extended receiver with my own Postmark provider to accomplish this for now.

Additional context

@hotmeteor
Copy link
Owner

Feel free to make a PR from your fork and I’ll check it out.

@hotmeteor
Copy link
Owner

@James4645 Anything to share here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants