Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with SQLite because "storage" parameter to Sequelize #59

Open
TCRTim opened this issue Jun 23, 2017 · 1 comment
Open

Doesn't work with SQLite because "storage" parameter to Sequelize #59

TCRTim opened this issue Jun 23, 2017 · 1 comment

Comments

@TCRTim
Copy link

TCRTim commented Jun 23, 2017

To work with a SQLite database, Sequelize needs a "storage" parameter but this handler doesn't have that ability so it always defaults to ":memory:".

I suggest the sequelizeArgs (sqlHandler.js line 47) variable needs to be updated to be able to pass the "storage" parameter.

I'd submit a Pull Request but my knowledge of Git is sadly lacking!

@pmcnr-hx
Copy link
Contributor

I had a quick look at supporting SQLite a while back and there are other issue that will need to be solved in addition to the above. I'm hoping to update the handler for the latest version of jsonapi-server soon and then I'll look into adding support for SQLite again. Meanwhile, any contributions and PRs are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants