Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/hide shimmer effect #47

Open
subzero911 opened this issue Apr 17, 2021 · 5 comments
Open

Show/hide shimmer effect #47

subzero911 opened this issue Apr 17, 2021 · 5 comments

Comments

@subzero911
Copy link

subzero911 commented Apr 17, 2021

Expected behaviour - when enabled: false, hide shimmer effect but show children
Current behaviour - stops the animation.
Because of it I have to create 2 trees - a shimmer tree with fake widgets and a tree with actual widgets
image

Please consider using enabled to show/hide shimmering, and period: 0 is for stopping the animation

@subzero911
Copy link
Author

subzero911 commented Apr 19, 2021

Or I'd suggest to deprecate parameter enabled as non-obvious, and introduce visible: true/false and animation: true/false instead.

@CripyIce
Copy link

@subzero911 I vote for that, really confusing and make you double the widgets.

@adschi
Copy link

adschi commented Aug 26, 2021

any updates on this?

@mdmota
Copy link

mdmota commented Mar 4, 2022

this feature would be too much.
stop animation doesn't make much sense.

@subzero911
Copy link
Author

this feature would be too much. stop animation doesn't make much sense.

I am agree with this point. Then let's return to the idea I suggested in a start post. Rename enabled to visible and make use it to show/hide shimmer effect and those people who wants to stop animation for some reason will use period: 0.

@subzero911 subzero911 changed the title enabled property stops the animation? Show/hide shimmer effect Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants