Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting minimum duration limit #107

Open
bagooba opened this issue Mar 7, 2023 · 2 comments
Open

Setting minimum duration limit #107

bagooba opened this issue Mar 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@bagooba
Copy link

bagooba commented Mar 7, 2023

Hi there! I noticed that you have a way to define the maximum duration fraction - is there any reason you don't have the option for a minimum? I find that the code often underestimates the duration, so it can keep discovering the same transits over and over again before moving on. I often look for long-period planets, so being able to set a minimum duration limit (especially when using 30 minute cadence data) would be very useful, and from looking at the source code I don't think it would be too difficult to implement.

@bagooba bagooba added the enhancement New feature or request label Mar 7, 2023
@hippke
Copy link
Owner

hippke commented Mar 9, 2023

There is currently no way to directly limit transit duration, neither max nor min. Their values are calculated based on physical limits (link to code line). Ad hoc, you could edit these lines directly to modify your search.
Alternatively, you can change the stellar mass and radius parameters which affects the T14 calculation (but beware, it also affects the period grid).
Note that very short transit durations are plausible because they can be grazing.

@LucaNap
Copy link

LucaNap commented Jan 18, 2024

I feel like this would be very helpful anyway. It might not be the default, but sometimes there's a need to look for specific durations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants