Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shader.js to remove the dependency on specific shader code #24

Open
06wj opened this issue Aug 13, 2020 · 0 comments
Open

Refactor shader.js to remove the dependency on specific shader code #24

06wj opened this issue Aug 13, 2020 · 0 comments
Labels
enhancement New feature or request
Projects
Milestone

Comments

@06wj
Copy link
Member

06wj commented Aug 13, 2020

In Shader.js:

import basicFragCode from './basic.frag';
import basicVertCode from './basic.vert';
import geometryFragCode from './geometry.frag';
import pbrFragCode from './pbr.frag';

These dependent shaders should be placed in mateiral.

@06wj 06wj added this to To do in Roadmap via automation Aug 13, 2020
@06wj 06wj added the enhancement New feature or request label Aug 13, 2020
@06wj 06wj added this to the next milestone Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Roadmap
  
To do
Development

No branches or pull requests

1 participant