Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command line option for jar file matching #26

Open
danielgrahl opened this issue Dec 16, 2021 · 7 comments
Open

command line option for jar file matching #26

danielgrahl opened this issue Dec 16, 2021 · 7 comments

Comments

@danielgrahl
Copy link

In the scanner, the file name extensions are hard-coded to jar/war/ear; at least rar (resource adapter archive) is missing.
It would be a great improvement to configure the file names to match on the command line, e.g., log4j-vuln-scanner --jarfiles jar,war,ear,rar

@martin-schlossarek
Copy link
Contributor

Do you have any real world examples for this? Could this also apply to *.zip or other file containers?

@hillu
Copy link
Owner

hillu commented Dec 16, 2021

Sure. If anyone does a PR, I'd accept that.

@martin-schlossarek
Copy link
Contributor

Now I get it.

I didn't know there are two different RAR file formats.

@danielgrahl
Copy link
Author

it's just some other name for a jar. But you are right, any zip should be considered.

@StyleTec
Copy link

StyleTec commented Dec 16, 2021

Zip magic is just 0x504B0304 at offset 0 fyi

@martin-schlossarek
Copy link
Contributor

it's just some other name for a jar. But you are right, any zip should be considered.

Do you have any example files? Googling for java+rar is useless: just winrar related results.

@hillu
Copy link
Owner

hillu commented Dec 16, 2021

But you are right, any zip should be considered.

Not by default. This tool is intended for quick assessments.

Like I said, I'll happily take pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants