Fix adding targets for collected data with multiple entries #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #673 +/- ##
===========================================
- Coverage 55.41% 55.39% -0.02%
===========================================
Files 130 130
Lines 8498 8501 +3
===========================================
Hits 4709 4709
- Misses 3789 3792 +3
Continue to review full report at Codecov.
|
andrewtpham
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the Purpose?
Update how
targetsfor different periods are calculated when a collected data has several entries.What was the approach?
Save
periodic target idin an array so that the target is not added twiceAre there any concerns to addressed further before or after merging this PR?
None
Mentions?
@andrewtpham @sannleen
Issue(s) affected?
Closes #646