Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous lines? #53

Open
pdesmarets opened this issue Sep 3, 2015 · 3 comments
Open

Extraneous lines? #53

pdesmarets opened this issue Sep 3, 2015 · 3 comments
Milestone

Comments

@pdesmarets
Copy link

Couldn't this output from the compiler:

    "allOf":[
        {
            "$ref":"http://www.jsonix.org/jsonschemas/w3c/2001/XMLSchema.jsonschema#/definitions/string"
        }
    ]
...

just as simply be written as:

"type":"string"

Same thing for boolean?

@highsource
Copy link
Owner

In principle, yes, but I'd prefer referencing an XML Schema type. There are also ints and integers and they have to be used form XMLSchema.jsonschema as they have constraints imposed by the XML Schema specs.

So that would be a bit weird to have "type":"string" in one place and references to XMLSchema.jsonschema on other. I'd prefer homogeneous type referencing. What do you think?

@pdesmarets
Copy link
Author

I'm no specialist. Personally, I think that the reference, if it doesn't add value, makes the file less legible. So I did a find/replace for the 70+ cases in my file. Maybe an option could leave the choice to the operator. Same thing when all the namespaceURI are all identical. Some people like verbose outputs, others like succinct...

@highsource
Copy link
Owner

Yes, makes sense. But I won't leave it to the user.

@highsource highsource added this to the 2.3.x milestone Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants