Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal (comma) separated values not working when importing a CSV #201

Open
sampoturve opened this issue Nov 6, 2019 · 0 comments
Open

Comments

@sampoturve
Copy link

sampoturve commented Nov 6, 2019

Expected behaviour

When importing a CSV in standalone Modal Editor (or Full editor) with values that have comma-separated decimal values in it (32,56), the CSV import should be able to import them as decimal values to the "Chart data".

Actual behaviour

When importing CSV with comma-separated decimal values, the comma is removed, turning 32,56 into 3256.

This was originally found when we were using editor.dataTable.loadCSV() to automatically populate the editor data with previously added values, and noticed that this happens on the Import UI as well.

It's possible that this is expected behavior as decimal separators are periods by default, so I'm unsure if this is really an issue or not, but I'd like to be sure.

Reproduction steps

"Column 1";"Column 2"
"A";"20,33"
"B";"40,21"
"C";"88,9821"
  • Values are imported without commas, turning them from 20,33 to 2033 and so on.

Editor version

0.2.2

Affected browser(s)

All

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant