Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: migrate OverlayProcess background to kagerou #69

Open
hibiyasleep opened this issue Sep 9, 2017 · 1 comment
Open

Enhancement: migrate OverlayProcess background to kagerou #69

hibiyasleep opened this issue Sep 9, 2017 · 1 comment
Labels
ACT-related enhancement WSOverlay related

Comments

@hibiyasleep
Copy link
Owner

hibiyasleep commented Sep 9, 2017 •
edited

Problem 1

Sentry log (not helpful): https://s.hibiya.moe/share/issue/322e36/

Reason: OverlayWindow's background feature try to access document.body.style, even document isn't fully loaded.

image

This exception was reported 6.8k times from 3.5k users, which all from OverlayProcess users.

cc @ZCube
@hibiyasleep hibiyasleep changed the title OverlayProcess causes "Cannot read property 'style' of null" Enhancement: migrate OverlayProcess background to kagerou Sep 9, 2017
@hibiyasleep
Copy link
Owner Author

Enhancement

Detect document.body.style.backgroundImage, then migrate it to config.style.table-bg-image. (+ notification)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ACT-related enhancement WSOverlay related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hibiyasleep