Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you add Effective Healing and Damaged Barrier stats? "Effective Healing %", "Effective Healing Per Second", #191

Open
JaneSmith opened this issue Feb 18, 2022 · 1 comment

Comments

@JaneSmith
Copy link

Hey there. I've been comparing different parser overlays, and the one I keep coming back to is Kagerou. The UI you've put together is just awesome and beats everything else. Kagerou looks so clean and easy on the eyes. I love it.

But some of the other ones (MopiMopi and Ember) support some extra information that Kagerou seems to be missing:

  • Effective Healing Total — This is the player's Healing Total subtracted by their Overheal Total.
  • Effective Healing % — This is the player's individual share of effective healing, i.e. add up everyone's Effective Healing Total, and then see what % this player contributed to that number.
  • Effective Healing Per Second
  • Effective Barrier Total (i.e. Damaged Barrier Total) — This is the amount of damage that was absorbed by the player's applied barriers (shields).

I'd also like to be able to sort by "Effective Healing %".

Would it be possible for you to add these to Kagerou? Thanks!

@Sundava
Copy link
Contributor

Sundava commented Feb 23, 2022

I've created a draft PR, but I can't test it in-game right now and I'm not really confident about the Effective Barrier Total (Especially how it interacts with shields that weren't consumed)
If you want, you can use https://sundava.github.io/kagerou/overlay/ as an URL to test it, I'd be grateful to know if it a 1000 shield that absorbed 300 damage is counted as a 300 or 1000 absorb.

Otherwise, I'll test it somewhere during the weekend and mark the PR as ready

Sundava added a commit to Sundava/kagerou that referenced this issue Feb 25, 2022
Sundava added a commit to Sundava/kagerou that referenced this issue Mar 8, 2022
Sundava added a commit to Sundava/kagerou that referenced this issue Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants