Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2FA option #781

Open
supersimple opened this issue May 10, 2020 · 2 comments
Open

Add 2FA option #781

supersimple opened this issue May 10, 2020 · 2 comments

Comments

@supersimple
Copy link
Member

2FA is offered on hexpm now.
It would be nice to have the same auth option for the CLI
This includes:
[ ] modifying the auth API

If a user enables 2FA on hex.pm, should that also enable it on the CLI? or 2 separate settings?
Should/Could there be a way to enable it from the CLI?

@ericmj @wojtekmach WDYT?

@ericmj
Copy link
Member

ericmj commented May 10, 2020

If you enable 2FA it should be enabled on the CLI as well but probably only for authentication a new user (when we generate API keys) and when publishing. There should also be an option when generating API keys that do not require 2FA so that you can still publish etc. in automated environments such as CI.

@ericmj
Copy link
Member

ericmj commented May 10, 2020

We need to inform users that when they enable 2FA they need to update their CLI clients to minimum X version.

There could be a use case for users that already enabled 2FA on the website to have an explicit opt-in for the CLI since we do not want their clients to suddenly break when we enable this feature and they haven't updated their clients yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants