[Bug] Import older backups

[jaapmarcus]

### Describe the bug

#   -- WEB --
#   2024-01-26 07:28:34 vesta09823.tld
#   chown: invalid group: ‘testbk-5285_ftp1:testbk-5285_ftp1’

Need to check what goes wrong maybe we need alter the restore process for older backups

Tell us how to replicate the bug

Check Drone:

https://drone.hestiacp.com/hestiacp/hestiacp/4035/1/6

Which components are affected by this bug?

Control Panel Command Line Interface

Hestia Control Panel Version

1.9.x

Operating system

N/A

Log capture

# -- command failed --
# status : 12
# output (22 lines):
#   2024-01-26 07:27:34 Load Average 1
#   
#   -- WEB --
#   2024-01-26 07:28:34 vesta09823.tld
#   chown: invalid group: ‘testbk-5285_ftp1:testbk-5285_ftp1’

[Skamasle]

There is any "old" backup for test ?

Its a vesta backup ?

[jaapmarcus]

hestiacp/test/restore.bats

Line 468 in 5ed6218

local archive_name="vesta09823.2018-10-18"

• next line

[jaapmarcus]

So: https://storage.hestiacp.com/testing/data/vesta09823.2018-10-18.tar

[Skamasle]

That file restored fine in 1.8.x

And drone say just fail in ubuntu ? :S

[jaapmarcus]

That file restored fine in 1.8.x

And drone say just fail in ubuntu ? :S

Drone tests again 1.9 ...

[Skamasle]

I investigate this, and this not is a v-restore-user problem this is a add_chroot_jail function problem

The error comes from

https://github.com/hestiacp/hestiacp/blob/cabea6a621a3fa663b1f822f25fa281129348c73/func/main.sh#L1785C27-L1785C28

v-restore-user call rebuild_web_domain_conf 2 times

When rebuild first time the FTP user not exists, this rebuild create the user, so second time not get any error

So you can reproduce this error when add ftp account:

v-add-web-domain-ftp admin hestia.test.net  test  password
chown: invalid group: 'admin_test:admin_test'

[Skamasle]

Posible solution for this:
Change
$BIN/v-add-user-sftp-jail "$ftp_user"

for

$BIN/v-add-user-sftp-jail "$user"
in

hestiacp/bin/v-add-web-domain-ftp

Line 113 in cabea6a

$BIN/v-add-user-sftp-jail "$ftp_user"

FTP user not have group, and have same GID/UID than original user, so I think can be valid and safe.

THis solve backup problem and v-add-web-domain-ftp, issue.