Fixed Sonarqube secrets definition

[eko]

What is the issue?:

When I try to install the Sonarqube chart, with a database (mysql or postgresql) enabled, I get the following error message:

Error: UPGRADE FAILED: no Secret with the name "yatta-toolkit-postgresql" found

How to fix it:

This is due to the https://github.com/helm/charts/blob/master/stable/sonarqube/templates/secret.yaml file which contains wrong conditions (enabled should be set to true instead of false).

Thank you

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eko
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rjkernick

If they are not already assigned, you can assign the PR to them by writing /assign @rjkernick in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/sonarqube/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rjkernick]

Please fix the developer commit signoff: https://github.com/helm/charts/pull/7641/checks?check_run_id=16471009

Also, you need to increment the version in Chart.yaml

[rjkernick]

/assign

[eko]

Hello @rjkernick, developer commit signoff and chart version increment are fixed.

Thank you

[rjkernick]

/ok-to-test

[k8s-ci-robot]

@eko: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-charts-e2e	6870fdc	link	/test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rjkernick]

After taking a second look through your pull request, I am not sure the updates are needed. Can you send some example overrides you are using to see that behavior?

The default behavior is you only need to create that secret when you are using a postgres or mysql that is not managed by the helm chart. If you use the defaults of the chart, it will spin up a postgres db. When it does that it will use the secret the postgres chart creates.

[eko]

Thank you for your help on this subject @rjkernick, indeed this condition is correct. It was not clear for me.

I close this PR as there is no issue on it.