Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use-case specific naming in Tree #335

Open
TysonMN opened this issue Sep 6, 2021 · 2 comments
Open

Use-case specific naming in Tree #335

TysonMN opened this issue Sep 6, 2021 · 2 comments

Comments

@TysonMN
Copy link
Member

TysonMN commented Sep 6, 2021

I would prefer if the Tree type, module, and function used language that was use-case agnostic. Instead, for example, the function that returns the root of the tree is called outcome.

@ghost
Copy link

ghost commented Sep 11, 2021

I noticed this naming as well. Bad naming isn't limited to just the tree module, of course. But I'm okay with changing the names in this module to be more general. What names would you propose we use here going forward?

@TysonMN
Copy link
Member Author

TysonMN commented Sep 12, 2021

From memory, there are the renames that I recall wanting.
Tree.outcome -> Tree.root
Tree.shrinks -> Tree.children

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant