New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object.defineProperty polyfill breaks any other library dependent on that method. #44

Open

GoogleCodeExporter opened this issue Aug 24, 2015 · 1 comment

Labels

auto-migrated Priority-Medium Type-Defect

GoogleCodeExporter commented Aug 24, 2015

What steps will reproduce the problem?
1. Object.defineProperty polyfill is not correct
2. It checks whether __defineGetter__ etc. is defined, which is deprecated.
3. Solution: Don't manipulate defineProperty if it's available. No other && is 
required.

Original issue reported on code.google.com by cmarten...@gmail.com on 26 Sep 2013 at 12:34

The text was updated successfully, but these errors were encountered:

Author

GoogleCodeExporter commented Aug 24, 2015

Addition: Object.prototype.defineProperty is the incorrect check, because it's 
a static method, not available on Object instances only (which is the prototype 
behaviour in native JS data types). So the check should be against 
Object.defineProperty.

Original comment by cmarten...@gmail.com on 26 Sep 2013 at 12:36

GoogleCodeExporter added Type-Defect auto-migrated Priority-Medium labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment