Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement percent_rank and cume_dist properly to ibis.omniscidb #5

Open
xmnlab opened this issue Dec 21, 2020 · 0 comments
Open

Implement percent_rank and cume_dist properly to ibis.omniscidb #5

xmnlab opened this issue Dec 21, 2020 · 0 comments
Projects

Comments

@xmnlab
Copy link
Contributor

xmnlab commented Dec 21, 2020

Ibis percent_rank doesn't implement the correct SQL percent_rank algorithm, instead it implements the algorithm for cume_dist, the same behavior of pandas (pandas-dev/pandas#28975).

Currently, ibis core has already percent_rank, so probably we can implement the percent_rank in the SQL way for now here.

for the cume_dist, maybe we can create the operator class here first, and open a PR (in parallel) to ibis core.

The work made at PR ibis-project/ibis#2224 can be used as reference/base.

@xmnlab xmnlab added this to In progress in Release 1.0 Feb 23, 2021
@xmnlab xmnlab moved this from In progress to To do in Release 1.0 Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant