Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#attach deletes image after attaching #46

Open
jonstorer opened this issue Jun 23, 2014 · 1 comment
Open

#attach deletes image after attaching #46

jonstorer opened this issue Jun 23, 2014 · 1 comment

Comments

@jonstorer
Copy link
Contributor

The attach method deletes the image it just attached when it's done.

  • This should not be the responsibility of the library. The library should rely on express (or the system) to clean up its own tmp files.

My integration tests attach images to object. In tests, I have to read my fixture file, create a tmp file for it, then attach it since mongoose-attachments is going to delete it. That's a lot of overhead for something the library shouldn't be doing.

@JakeBent
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants