Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce for simplify PR #27

Open
back2dos opened this issue Jul 21, 2021 · 2 comments
Open

Reduce for simplify PR #27

back2dos opened this issue Jul 21, 2021 · 2 comments

Comments

@back2dos
Copy link
Member

Still need to implement reduce for #24. After unsuccessfully banging my head against the wall for a while I'm gravitating towards thinking that reduce should be the basis of everything (and forEach is merely a reduce that accumulates Noise), but it's rather involved and I need to let the idea sink in, because I want to get things right this time around. The issue is here is just a reminder.

@back2dos back2dos mentioned this issue Jul 21, 2021
@kevinresol
Copy link
Member

kevinresol commented Jul 24, 2021

Will it cause problems if the compiler is able to (if it ever will) check for pureness of the reducer? Or is it just about the internals? Because I prefer having separated forEach and reduce in the public API

@back2dos
Copy link
Member Author

Oh, yeah. In the public API they should be separate things. My point is rather that implementing reduce over forEach is actually trickier than the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants