Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap error codes into 400-600 range #95

Open
back2dos opened this issue Apr 10, 2018 · 1 comment
Open

Wrap error codes into 400-600 range #95

back2dos opened this issue Apr 10, 2018 · 1 comment

Comments

@back2dos
Copy link
Member

When generating status codes from error codes, it should be % 200 + 400, to make sure it always comes out as an error code. It will thus be possible to introduce new error codes outside the HTTP range and let them be mapped to HTTP error codes nicely.
@kevinresol
Copy link
Member

kevinresol commented Apr 26, 2019 •
edited

Related: 13413e2

I added that because nodejs will crash when the status code is outside such range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@back2dos @kevinresol