Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:compileAotJava breaks because HawtioConfigurationProperties has private access in HawtioEndpointAutoConfiguration #2974

Open
arthurpessoa opened this issue Nov 7, 2023 · 1 comment

Comments

@arthurpessoa
Copy link

arthurpessoa commented Nov 7, 2023

hawtio = { group = "io.hawt", name = "hawtio-springboot", version = "4.0-M1" }
spring-boot = { id = "org.springframework.boot", version = "3.1.5" }

Problem:
After i've added hawtio to my springboot native app, the AoT breaks because HawtioConfigurationProperties has private access in HawtioEndpointAutoConfiguration, making impossible to generate the HawtioEndpointAutoConfiguration__BeanDefinitions

Possible Solution:
make this properties public

...
   public class HawtioEndpointAutoConfiguration {
....
    //private static class HawtioConfigurationProperties {
    public static class HawtioConfigurationProperties {
        private final Map<String, String> hawtio = new HashMap<>();

        public Map<String, String> getHawtio() {
            return hawtio;
        }
    }
...
@arthurpessoa arthurpessoa changed the title :compileAotJava breaks brecause HawtioConfigurationProperties has private access in HawtioEndpointAutoConfiguration :compileAotJava breaks because HawtioConfigurationProperties has private access in HawtioEndpointAutoConfiguration Nov 7, 2023
@tadayosi
Copy link
Member

tadayosi commented Nov 8, 2023

@arthurpessoa Thanks for your feedback. Have you confirmed that the proposed fix actually solves your issue? If it does, I'm happy to accept the change. Would you like to contribute a pull req for the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants