Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats collection causes unbounded memory growth, slowing RPS over time #364

Open
huntharo opened this issue Jan 8, 2024 · 1 comment
Open

Comments

@huntharo
Copy link
Contributor

huntharo commented Jan 8, 2024

Motivations

  • oha memory usage grows about 2 MB every couple of seconds under normal usage conditions at 11k RPS
  • After a few minutes, oha slows down to only 8-9k RPS
  • Restarting oha, but not the target of the test, restores the 11k RPS rate
  • It appears that the increasing memory usage for stats may be causing the reduction in performance over time
  • While the requests should not be slowed down by the stats collection, they are going to compete for CPU with the stats processing and the stats processing may be using more CPU as the collection of stats grows larger, which could explain why the RPS rate starts to drop

Slowing RPS Over Time

image

Restarting oha but not Target Restores RPS

image
@huntharo
Copy link
Contributor Author

huntharo commented Jan 8, 2024

Related to #361 as the unbounded stats collection is what ultimately caused the OOM kill due to fast looping on failing requests because the underlying connection was disconnected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant