Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non utf-8 chars in username field. #66

Open
i128 opened this issue Jun 7, 2022 · 1 comment
Open

Support for non utf-8 chars in username field. #66

i128 opened this issue Jun 7, 2022 · 1 comment
Labels
bug Something isn't working
Projects
Milestone

Comments

@i128
Copy link
Contributor

i128 commented Jun 7, 2022

Right now when a user submits a hashfile where the username contains a non utf-8 character (åøß e.g.) hashview cannot parse it correctly. Two potential fixes:

  1. hex/base64 encode user names:
    Pro: allows for quick solution
    Con: Harder to do case insensitive searches.

  2. Convert database language support to handle non utf-8 characters
    pro: allows for case insensitive searchs
    con: might require table migrations for existing hashfiles

if we go with second solution we should probably convert the hashes table too while we're at it.

@i128 i128 added the bug Something isn't working label Jun 7, 2022
@i128 i128 added this to the v0.8.2 milestone Jun 7, 2022
@Yoshi325 Yoshi325 added this to On Deck in v0.8.2 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
v0.8.2
On Deck
Development

No branches or pull requests

1 participant