Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tags to budgets resources #37361

Merged
merged 10 commits into from May 10, 2024
Merged

Added tags to budgets resources #37361

merged 10 commits into from May 10, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented May 8, 2024 •
edited

Description

This PR adds the tags & tags_all arguments to the following (data)-resources.

Resources:

  • aws_budgets_budget
  • aws_budgets_budget_action

Datasource:

  • aws_budgets_budget

Relations

Closes #37351
Closes #37350

References

Output from Acceptance Testing

aws_budgets_budget

make testacc TESTARGS='-run=TestAccBudgetsBudget_tags' PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/budgets/... -v -count 1 -parallel 20  -run=TestAccBudgetsBudget_tags -timeout 360m
=== RUN   TestAccBudgetsBudget_tags
=== PAUSE TestAccBudgetsBudget_tags
=== CONT  TestAccBudgetsBudget_tags
--- PASS: TestAccBudgetsBudget_tags (104.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    108.558s

aws_budgets_budget_action

make testacc TESTARGS='-run=TestAccBudgetsBudgetAction_tags' PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/budgets/... -v -count 1 -parallel 20  -run=TestAccBudgetsBudgetAction_tags -timeout 360m
=== RUN   TestAccBudgetsBudgetAction_tags
=== PAUSE TestAccBudgetsBudgetAction_tags
=== CONT  TestAccBudgetsBudgetAction_tags
--- PASS: TestAccBudgetsBudgetAction_tags (139.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    143.545s

data.aws_budgets_budget

make testacc TESTARGS='-run=TestAccBudgetsBudgetDataSource_basic' PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/budgets/... -v -count 1 -parallel 20  -run=TestAccBudgetsBudgetDataSource_basic -timeout 360m
=== RUN   TestAccBudgetsBudgetDataSource_basic
=== PAUSE TestAccBudgetsBudgetDataSource_basic
=== CONT  TestAccBudgetsBudgetDataSource_basic
--- PASS: TestAccBudgetsBudgetDataSource_basic (41.67s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    45.745s

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/budgets Issues and PRs that pertain to the budgets service. tags Pertains to resource tagging. generators Relates to code generators. labels May 8, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 8, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 9, 2024
DrFaust92
DrFaust92 approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jar-b
jar-b approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=budgets TESTS=TestAccBudgetsBudget
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/budgets/... -v -count 1 -parallel 20 -run='TestAccBudgetsBudget'  -timeout 360m

--- PASS: TestAccBudgetsBudget_disappears (40.20s)
--- PASS: TestAccBudgetsBudgetDataSource_basic (44.93s)
--- PASS: TestAccBudgetsBudget_Name_generated (49.31s)
--- PASS: TestAccBudgetsBudget_basic (49.80s)
--- PASS: TestAccBudgetsBudget_namePrefix (49.81s)
--- PASS: TestAccBudgetsBudget_autoAdjustDataForecast (49.85s)
--- PASS: TestAccBudgetsBudgetAction_disappears (50.20s)
--- PASS: TestAccBudgetsBudgetAction_basic (57.32s)
--- PASS: TestAccBudgetsBudgetAction_triggeredAutomatic (57.42s)
--- PASS: TestAccBudgetsBudgetAction_triggeredManual (57.63s)
--- PASS: TestAccBudgetsBudget_costTypes (74.64s)
--- PASS: TestAccBudgetsBudget_autoAdjustDataHistorical (77.09s)
--- PASS: TestAccBudgetsBudget_plannedLimits (77.09s)
--- PASS: TestAccBudgetsBudget_notifications (78.03s)
--- PASS: TestAccBudgetsBudget_tags (103.50s)
--- PASS: TestAccBudgetsBudgetAction_tags (132.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    137.184s

@jar-b
Copy link
Member

jar-b commented May 10, 2024

Thanks for your contribution, @DanielRieske! 👍

@jar-b jar-b merged commit 44b6464 into hashicorp:main May 10, 2024
42 of 43 checks passed
@github-actions github-actions bot added this to the v5.50.0 milestone May 10, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/budgets Issues and PRs that pertain to the budgets service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.50.0
4 participants
@DanielRieske @jar-b @DrFaust92 @justinretzolk