Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially support Kubernetes native sidecars #3919

Open
komapa opened this issue Apr 18, 2024 · 0 comments
Open

Officially support Kubernetes native sidecars #3919

komapa opened this issue Apr 18, 2024 · 0 comments
Labels
type/enhancement New feature or request

Comments

@komapa
Copy link

komapa commented Apr 18, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

Yes, very similar to the corresponding vault-k8s ask here: hashicorp/vault-k8s#620

See: https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/

Feature Description

Implement annotation globally and/or per Pod where we can tell consul-k8s to inject the consul-dataplane container in initContainers with the restartPolicy: Always. Thinking about it, this is the only thing that needs to be done to have the consul-dataplane run before the main containers and also to NOT block shutdown of Jobs.

Use Case(s)

Solve a whole slew of issues which we have to now manually work around with shutdown delays and startup checks in the main container.

Contributions

@komapa komapa added the type/enhancement New feature or request label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant