Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting only the registry for docker images in the helm chart instead of full URI #3425

Open
komapa opened this issue Dec 22, 2023 · 2 comments
Labels
type/enhancement New feature or request

Comments

@komapa
Copy link

komapa commented Dec 22, 2023

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

Yes. Let me explain :)

We are mirroring all of consul-k8s dependent images in our private registry in the following format:

      global:
        image: ${local.registry}/hub/hashicorp/consul-enterprise:${local.consul_version}
        imageK8S: ${local.registry}/hub/hashicorp/consul-k8s-control-plane:${local.consul_chart_version}
        imageConsulDataplane: ${local.registry}/hub/hashicorp/consul-dataplane:${local.consul_chart_version}

The immediate problem is that releases for 1.1.x do not track the same versioning in consul-dataplane project! consul-k8s is at 1.1.8 but consul-dataplane is at 1.1.7 and the above logic fails while it works perfectly for 1.2.x and 1.3.x series.

Feature Description

It will be great if we can just specify:

global:
   registry: ${local.registry}/hub/hashicorp

and then you fill in with consul-k8s-control-plane:1.1.8 and consul-dataplane:1.1.7 the rest.

Use Case(s)

Using private registries

@komapa komapa added the type/enhancement New feature or request label Dec 22, 2023
@dmpe
Copy link

dmpe commented May 21, 2024

Yes, this is pretty much required. No idea why it hasn't been done yet. It makes using renovate bot so much harder...

@komapa
Copy link
Author

komapa commented May 21, 2024

@david-yu if this is a "breaking change" like you mentioned in #644, can we at least bring consul-dataplane versioning in line with the versioning of consul-k8s? We got bit again just now because the official 1.1.11 was released and overwrite out mirrored image and started erroring for envoy.tracing (unrelated issue but proving the point).

Just make the versions at least match for 1.1.x just like they do for the other minor versions and will make the problem a little worse.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants