Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant env config values from helm charts #2476

Open
AlfredoG87 opened this issue May 11, 2024 · 0 comments
Open

Remove redundant env config values from helm charts #2476

AlfredoG87 opened this issue May 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@AlfredoG87
Copy link
Collaborator

AlfredoG87 commented May 11, 2024

Problem

The relay has the recommended and default values hardcoded within the app. however we are overriding these with the one with the chart values, what is forcing devs to update the defaults in both places when there is a change or optimization, and in some cases there is an inconsistency between them due to devs forget about the charts.

NOTE IMPORTANT:

There are already some outdated values for the charts, like:
Default on app:

  MIRROR_NODE_RETRIES: 0
  MIRROR_NODE_RETRY_DELAY: 2000
  HAPI_CLIENT_ERROR_RESET: [21,50]

Overriden on chart default values:

  MIRROR_NODE_RETRIES: 3
  MIRROR_NODE_RETRY_DELAY: 250
  HAPI_CLIENT_ERROR_RESET: [50]

There are more that change, so is necessary to evaluate if the difference is really needed...

Solution

review and remove all duplicate and default values from the chart values files.

review files:

leave as few configs on the values as possible only when there is a real need to have it different than the defaults on app.

Alternatives

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant