Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added fromBlock and toBlock parameters to getLogs and fixed typo. #2473

Closed
wants to merge 1 commit into from

Conversation

ebadiere
Copy link
Collaborator

Added toBlock and fromBlock parameters

Fixes #2464

@ebadiere ebadiere added the bug Something isn't working label May 10, 2024
@ebadiere ebadiere self-assigned this May 10, 2024
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Tests

    2 files  147 suites   13s ⏱️
819 tests 818 ✔️ 1 💤 0
831 runs  830 ✔️ 1 💤 0

Results for commit 42908bf.

Copy link

github-actions bot commented May 10, 2024

Acceptance Tests

     22 files     280 suites   32m 27s ⏱️
   577 tests    571 ✔️ 3 💤 3
1 091 runs  1 078 ✔️ 5 💤 8

Results for commit 42908bf.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need a test on validator.spec.ts?

@ebadiere ebadiere marked this pull request as draft May 14, 2024 01:00
@quiet-node
Copy link
Collaborator

quiet-node commented May 24, 2024

fixed in this PR #2521

@quiet-node quiet-node closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Logs subscription errors out when "FromBlock" is present
3 participants