Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: estimate_gas doesn't reflect changes in mirror-node #2409

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

victor-yanev
Copy link
Contributor

@victor-yanev victor-yanev commented Apr 25, 2024

Description:

Related issue(s):

Fixes #2379

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Copy link

github-actions bot commented Apr 25, 2024

Acceptance Tests

  18 files  255 suites   24m 43s ⏱️
585 tests 579 ✔️ 3 💤 3
904 runs  893 ✔️ 7 💤 4

Results for commit 9d8e21d.

♻️ This comment has been updated with latest results.

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
…t-changes-in-mirror-node

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

# Conflicts:
#	packages/relay/src/lib/eth.ts
…t-changes-in-mirror-node

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>

# Conflicts:
#	packages/relay/src/lib/eth.ts
Copy link

github-actions bot commented Apr 29, 2024

Tests

    2 files  147 suites   13s ⏱️
820 tests 819 ✔️ 1 💤 0
832 runs  831 ✔️ 1 💤 0

Results for commit 9d8e21d.

♻️ This comment has been updated with latest results.

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
@victor-yanev victor-yanev marked this pull request as ready for review April 29, 2024 14:49
@victor-yanev victor-yanev added the bug Something isn't working label May 2, 2024
Copy link
Collaborator

@konstantinabl konstantinabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Few nits

@konstantinabl
Copy link
Collaborator

If possible fix some of the SonarCloud issues

Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limechain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

estimate_gas doesn't reflect changes in mirror-node
2 participants