Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded Lyrics not Showing #473

Open
t800-x opened this issue Feb 13, 2024 · 4 comments
Open

Embedded Lyrics not Showing #473

t800-x opened this issue Feb 13, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@t800-x
Copy link

t800-x commented Feb 13, 2024

Sometimes the app would not show embedded lyrics in flac files. I couldn't notice a pattern to it, it just randomly happens.

There is also an issue with non-synced embedded lyrics. Synced lyrics are in the format [timestamp] - line, but the indexing algorithm tries to do the same for non-synced lyrics, a simple fix would be to check if the first character in the Lyrics tag starts with a '[', if it does then it shall be indexed normally but if it doesn't it should be indexed in a paragraph form instead of the standard key-value pairs.

OS: Windows 11 22H2

@t800-x t800-x added the bug Something isn't working label Feb 13, 2024
@t800-x
Copy link
Author

t800-x commented Feb 13, 2024

Just for clarification, the embedded lyrics sometimes work, sometimes they don't.

@Red6785
Copy link

Red6785 commented Feb 18, 2024

Are you certain that Harmonoid reads embedded lyrics at all? I was under the impression it didn't, based on the fact that none of mine are being read. Try clearing the selected LRC file and disabling your internet connection for a moment - I think it might be that you're fetching lyrics from the database and they just align with your embedded stuff well.

@t800-x
Copy link
Author

t800-x commented Feb 18, 2024

Are you certain that Harmonoid reads embedded lyrics at all? I was under the impression it didn't, based on the fact that none of mine are being read. Try clearing the selected LRC file and disabling your internet connection for a moment - I think it might be that you're fetching lyrics from the database and they just align with your embedded stuff well.

Yeah, I think that might be the case.

@t800-x t800-x closed this as not planned Won't fix, can't repro, duplicate, stale Feb 18, 2024
@alexmercerind
Copy link
Member

alexmercerind commented Feb 18, 2024

Yeah, embedded lyrics aren't read in current version. Only .LRC files with same name as file in same folder & the API that we use.

It should be easy to have this implemented.

@alexmercerind alexmercerind reopened this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants